Skip to content

change start to run #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keloyang wants to merge 1 commit into from
Closed

change start to run #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test_runtime.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ trap cleanup EXIT
tar -xf rootfs.tar.gz -C ${TESTDIR}
cp runtimetest ${TESTDIR}

ocitools generate --output "${TESTDIR}/config.json" "${TEST_ARGS[@]}" --rootfs '.'
ocitools generate --tty --output "${TESTDIR}/config.json" "${TEST_ARGS[@]}" --rootfs '.'
Copy link

@Mashimiao Mashimiao Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If docker-runc failed without --tty. I think that's docker-runc's problem. The spec says /dev/console is the default device for Linux which must be supplied by runtime.

Copy link
Author

@keloyang keloyang Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--tty is unnecessary , add it we can see the output info,wouldn't it be better?

Copy link

@Mashimiao Mashimiao Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 08/05/2016 04:27 PM, keloyang wrote:

--tty is unnecessary , add it we can see the output info,wouldn't it be better?

Sorry, I'm not sure what you wanted to express. more detailed?

Copy link
Author

@keloyang keloyang Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug info, such as DEBU[0000] validating ...

Copy link

@Mashimiao Mashimiao Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 08/05/2016 05:30 PM, keloyang wrote:

debug info, such as DEBU[0000] validating ...
That is not --tty's function.
If you want info like that, you just need to execute test_runtime.sh with -l debug.
--tty is not necessary.


TESTCMD="${RUNTIME} start $(uuidgen)"
TESTCMD="${RUNTIME} run $(uuidgen)"
pushd $TESTDIR > /dev/null
if ! ${TESTCMD}; then
error "Runtime ${RUNTIME} failed validation"
Expand Down