change start to run

[keloyang]

I Follow the instructions(README.md), and "./test_runtime.sh -r docker-runc" execute failed. So I have this modify.

• runc start failed if it has no runc create ,so change start to run (create+start), it will avoid "**/state.json: no such file or directory" error.
• add --tty to command ,the generated config.json will has"terminal: true", it will avoid the "/dev/console not found" error.
  then I can see the validation.

root@ubuntu:****opencontainers/ocitools# ./test_runtime.sh -r docker-runc -l debug
-----------------------------------------------------------------------------------
VALIDATING RUNTIME: docker-runb
-----------------------------------------------------------------------------------
DEBU[0000] validating root filesystem                   
DEBU[0000] validating container process                 
DEBU[0000] validating capabilities                      
DEBU[0000] validating hostname                          
DEBU[0000] validating rlimits                           
DEBU[0000] validating mounts exist                      
DEBU[0000] validating linux default filesystem          
DEBU[0000] validating linux default devices             
DEBU[0000] validating sysctls                           
DEBU[0000] validating maskedPaths                       
DEBU[0000] validating readonlyPaths                     
Runtime docker-runb passed validation

Signed-off-by: Shukui Yang yangshukui@huawei.com

[Mashimiao]

If docker-runc failed without --tty. I think that's docker-runc's problem. The spec says /dev/console is the default device for Linux which must be supplied by runtime.

[keloyang]

--tty is unnecessary , add it we can see the output info,wouldn't it be better?

[Mashimiao]

On 08/05/2016 04:27 PM, keloyang wrote:

--tty is unnecessary , add it we can see the output info,wouldn't it be better?

Sorry, I'm not sure what you wanted to express. more detailed?

[keloyang]

debug info, such as DEBU[0000] validating ...

[Mashimiao]

On 08/05/2016 05:30 PM, keloyang wrote:

debug info, such as DEBU[0000] validating ...
That is not --tty's function.
If you want info like that, you just need to execute test_runtime.sh with -l debug.
--tty is not necessary.

[wking]

With runtime-spec 1.0.0-rc1, ‘start’ has been replaced by ‘create’ and ‘start’ (opencontainers/runtime-spec#384). ‘run’ is specific to runC, and ocitools should stick to the spec'ed API.

[keloyang]

thank you, I think I can close this pr.