Skip to content

Conversation

@laijs
Copy link
Contributor

@laijs laijs commented Aug 31, 2015

No description provided.

laijs added 2 commits August 31, 2015 22:15
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
@laijs
Copy link
Contributor Author

laijs commented Aug 31, 2015

@jonboulle @wking the last commit of #128 is updated and moved here
conflicted with the ummerged #99 from @wking.

@wking
Copy link
Contributor

wking commented Aug 31, 2015

On Mon, Aug 31, 2015 at 07:24:33AM -0700, Lai Jiangshan wrote:

  • rename the "Control groups" to "Resources" and update the description

“Control groups” are a Linux feature I'd heard of before runC.
“Resources” could be anything. If we really do step outside of
cgroups here, I'm ok with a structure like:

Resource

Limit the resources that can be used by your container. Bla bla
bla…

Control groups

Bla bla bla…

You can also setup device cgroups via
devices.

Other resource limit that's not covered by control groups

Bla bla bla…

Although with #99, I've proposed shifting the device-cgroup setup into
the cgroups structure, so it's not squashed in with mknod control.

@wking
Copy link
Contributor

wking commented Aug 31, 2015

On Mon, Aug 31, 2015 at 07:27:47AM -0700, Lai Jiangshan wrote:

the last commit of #128 is updated and moved here conflicted with
the ummerged #99 from @wking.

I like #99, but I wouldn't worry about conflicts with it in other pull
requests until it attracts more interest ;). So far it's been almost
a month with no non-me comments, so blocking anything else on #99 will
probably just kill the blocked thing :p.

@wking
Copy link
Contributor

wking commented Sep 2, 2015 via email

@laijs
Copy link
Contributor Author

laijs commented Sep 11, 2015

a example is added by another pr, close it

@laijs laijs closed this Sep 11, 2015
@laijs laijs deleted the update-cgroup branch September 17, 2015 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants