Header cleanup #128
Merged
Header cleanup #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
NACK on d9ed9b0 - that section is specifically cgroups, not resources generally (e.g rlimits provide another means of resource limiting) |
Contributor
Author
|
@jonboulle in the .go file, its name is "Resources", and the user should also define a "Resources" in his config.json (instead of "cgroup" or something else). The spec (*.md) and the user config (config.json) should be consistent. Maybe we should also add an example for it in this .md. I will just drop this change and and update the other 2 commits as @wking suggested. |
Closed
Contributor
|
With the tip at 750763, this looks good to me.
|
Contributor
Author
|
Anyone objects the first commit? |
Contributor
Contributor
Author
|
ping |
Contributor
|
@laijs could you squash the commits? |
…nfig And also fix the header size Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
laijs
force-pushed
the
header-cleanup
branch
from
750763a to
004ec55
Compare
Contributor
Author
|
@mrunalp done |
Contributor
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.