Unify behavior for memory cgroup #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a rule that for optional cgroups, don't fail if some of them are not mounted, but we want it fail hard when a user specifies an option and we are unable to fulfill the request. Memory cgroup should also follow this rule. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Contributor
Contributor
Author
|
@rajasec This new change still includes that fix, in another way. If memory cgroup is not mounted and user is not using memory options, it won't fail. |
Contributor
There was a problem hiding this comment.
@hqhq
if memory subsystem is not mounted, empty path is passed in set interface ? is that correct ?
Contributor
Author
There was a problem hiding this comment.
Yes, it's intended, so that we can get error in writeFile function.
Member
|
LGTM |
Contributor
There was a problem hiding this comment.
@hqhq
if path not equal to empty( which means path exists), code is creating mkdir again with "path"
is that intentional ?
Contributor
Author
There was a problem hiding this comment.
How "again"? It's the first time we create "path".
Contributor
|
@hqhq |
Contributor
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Nov 2, 2015
Unify behavior for memory cgroup
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
…ormance Improve json encoding performance for specs-go
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Through 6734c7a (Merge pull request opencontainers#370 from vbatts/json_schema_and_examples, 2016-04-11). The only unlisted changes to master were a brief run with ffjson (opencontainers#343, opencontainers#351), but that was pulled out due to gccgo issues in opencontainers#363. Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a rule that for optional cgroups, don't fail if some
of them are not mounted, but we want it fail hard when a
user specifies an option and we are unable to fulfill the
request.
Memory cgroup should also follow this rule.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com