manifest.go:remove the size of the layers of judgment #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Tue, Nov 29, 2016 at 05:53:42PM -0800, Zhou Hao wrote:
… the minimum length of the layer has been verified in JSON, so the
code is redundant.
That landed in opencontainers/image-spec#466, which is currently
unreleased. Once image-spec cuts rc3 (opencontainers/image-spec#477)
and image-tools bumps to pick that up, f5d7ced will look good to me.
|
|
@coolljt0725 @xiekeyang PTAL |
|
@q384566678 we need to bump the image-spec to rc3 first |
@coolljt0725 I don't quite understand why . |
|
@q384566678 as said by @wking in #90 (comment) |
|
@coolljt0725 That PR(opencontainers/image-spec#477) has been merged, it has become rc3. |
|
@q384566678 but image-tool doesn't bump it yet. https://github.com/opencontainers/image-tools/blob/master/glide.yaml#L3 |
zhouhao3
force-pushed
the
add-layers
branch
2 times, most recently
from
d0bfe3e to
90794e0
Compare
|
@coolljt0725 It can be directly modified like this? |
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
@coolljt0725 @xiekeyang @vbatts @stevvooe rebased #102 PTAL |
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this ，we can see the minimum length of the layer has been verified in JSON, so the code is redundant.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com