Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete does not exist properties #102

Merged
merged 1 commit into from
Jan 20, 2017

Conversation

zhouhao3
Copy link

Make the following changes according to opencontainers/image-spec#495
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

@coolljt0725
Copy link
Member

We need to bump the image-spec first

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Author

@coolljt0725 updated.Thank you so much for your suggestion.
@xiekeyang @stevvooe PTAL

@coolljt0725
Copy link
Member

coolljt0725 commented Jan 17, 2017

@q384566678 AFAIK, these being removed field does not in v1.0.0-rc3, I think we should wait the opencontainers/image-spec#495 being land on next release and then bump the image-spec.

@stevvooe
Copy link
Contributor

stevvooe commented Jan 17, 2017

LGTM

Approved with PullApprove

1 similar comment
@xiekeyang
Copy link
Contributor

xiekeyang commented Jan 20, 2017

LGTM

Approved with PullApprove

@xiekeyang xiekeyang merged commit 6e09f9d into opencontainers:master Jan 20, 2017
@zhouhao3 zhouhao3 deleted the config-delet branch January 20, 2017 07:26
@wking wking mentioned this pull request Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants