feat: consistent entity names in continuous text #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes inline entity names by replacing straight quotation marks with guillemet-style quotes (»…«) across UI messages and tests.
- Replaced
"%{name}"with guillemet syntax»%{name}«in gettext and ngettext calls - Updated corresponding unit tests to expect the new quote style
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/tests/unit/composables/actions/helpers/useIsResourceNameValid.spec.ts | Updated expected error messages to use guillemet quotes |
| packages/web-pkg/src/helpers/resource/conflictHandling/transfer.ts | Replaced straight quotes in failure titles |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsSetIcon.ts | Swapped quotes around space name |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsRestore.ts | Updated quotes in restore success/failure titles and prompts |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsEditQuota.ts | Swapped quotes in quota edit title |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsDuplicate.ts | Replaced quotes in duplicate success/failure messages |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsDisable.ts | Updated quotes in disable success/failure titles and modal prompts |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsDeleteImage.ts | Swapped quotes in delete-image modal |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsDelete.ts | Replaced quotes in delete-space messages and prompts |
| packages/web-pkg/src/composables/actions/helpers/useIsResourceNameValid.ts | Updated conflict error message quoting |
| packages/web-pkg/src/composables/actions/helpers/useFileActionsDeleteResources.ts | Swapped quotes in delete-resources titles |
| packages/web-pkg/src/composables/actions/files/useFileActionsRename.ts | Updated rename failure and modal titles |
| packages/web-pkg/src/composables/actions/files/useFileActionsEmptyTrashBin.ts | Replaced quotes in empty-trash-bin modal |
| packages/web-pkg/src/composables/actions/files/useFileActionsCreateSpaceFromResource.ts | Swapped quotes in create-space prompts |
| packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts | Updated quotes in copy-link modal |
| packages/web-pkg/src/components/Modals/ResourceConflictModal.vue | Replaced quotes in conflict messages |
| packages/web-pkg/src/components/CreateShortcutModal.vue | Swapped quotes in shortcut name error |
| packages/web-app-files/src/composables/actions/spaces/useSpaceActionsUploadImage.ts | Updated title to include space name |
| packages/web-app-external/src/App.vue | Replaced quotes in export/save modals |
| packages/web-app-admin-settings/src/composables/actions/users/useUserActionsEditQuota.ts | Swapped quotes in user quota title |
| packages/web-app-admin-settings/src/composables/actions/groups/useGroupActionsDelete.ts | Updated quotes in group delete titles and prompts |
packages/web-pkg/src/composables/actions/files/useFileActionsRename.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsEmptyTrashBin.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/spaces/useSpaceActionsDeleteImage.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsRename.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsRename.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JammingBen
approved these changes
Jul 9, 2025
Contributor
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Let's hope the translation sync finally does its job at the end of the sprint 😄
kulmann
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes