Improve Trashbin

[AlexAndBear]

Description

Related Issue

• Fixes New action "empty trash" #892
• Fixes Add fillstate for deleted files in trash overview page #871
• Fixes Add view options filter "Show empty trash bins" to trash overview #907

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Types of changes

• Bugfix
• Enhancement (a change that doesn't break existing code or deployments)
• Breaking change (a modification that affects current functionality)
• Technical debt (addressing code that needs refactoring or improvements)
• Tests (adding or improving tests)
• Documentation (updates or additions to documentation)
• Maintenance (like dependency updates or tooling adjustments)

[streaminganger]

Hey sorry outsider input here. 2 cents worth.

Since you are already dedicating an icon to indicate the fill state, why not also make it useful by making it a clickable action - and it's greyed out because the trash is already empty - I think is quite intuitive too! :)

[AlexAndBear]

@streaminganger Thank you for your advice, that's a great and handy idea!

Unfortunately our status indicators are not made to call any actions, but we have quick actions for that in front of the 3-dot-menu.

What do you think?

[streaminganger]

Unfortunately our status indicators are not made to call any actions, but we have quick actions for that in front of the 3-dot-menu.

I see! In any case I do like the trash action shown upfront like this for a first time user viewing this page it helps.

Thanks for listening. I love the great work you do for FOSS!

[Copilot]

Pull Request Overview

This PR adds support for showing and hiding empty trash bins across the UI and implements the "empty trash bin" action for space-level trash views.

• Introduces a new areEmptyTrashesShown flag (with localStorage persistence) and UI toggle in the view options.
• Defines and wires up the empty-trash-bin space action (handler, visibility, disabled state) and adds quick/context actions for trash views.
• Extends SpaceResource with a hasTrashedItems property, adds corresponding status indicators, and updates both generic and trash-specific space views.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/web-runtime/src/container/bootstrap.ts	Initialize areEmptyTrashesShown from localStorage
packages/web-pkg/src/composables/piniaStores/resources.ts	Add areEmptyTrashesShown ref and setter
packages/web-pkg/src/composables/actions/files/useFileActionsEmptyTrashBin.ts	Implement empty-trash-bin action for spaces
packages/web-pkg/src/helpers/statusIndicators.ts	Add trash‐filled/empty indicators
packages/web-pkg/src/composables/piniaStores/spaces.ts	Add reloadPersonalSpace method
packages/web-client/src/helpers/space/types.ts & functions.ts	Extend SpaceResource with hasTrashedItems default
packages/web-pkg/src/components/ViewOptions.vue	Add switch to toggle empty trash bins
packages/web-pkg/src/components/FilesList/ResourceTable.vue	Filter out trash indicators in non‐trash listings
packages/web-app-files/src/views/trash/Overview.vue	Integrate empty‐trash toggle, quick/context actions in overview
packages/web-app-files/src/views/spaces/GenericTrash.vue	Add “Empty trash bin” button to generic space trash view

Comments suppressed due to low confidence (1)

packages/web-pkg/src/components/ViewOptions.vue:78

• [nitpick] This new switch shares the same data-testid as the disabled‐spaces toggle. Please update it to a unique identifier (e.g. files-switch-show-empty-trash) to avoid test collisions.

            data-testid="files-switch-projects-show-disabled"

[Copilot]

The ContextActions import is no longer used in this file. You can remove it to keep imports tidy.

[Copilot]

[nitpick] Using action.label() as the list key may lead to duplicate keys if labels repeat. Consider using action.name for a stable, unique key.

Suggested change

	:key="action.label()"
	:key="action.name"

[AlexAndBear]

😮‍💨 ready 2 review
have phun

[JammingBen]

Very nice 🏅