Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

What Changed:

  • Added dedicated accessibility (a11y) test suite to CI pipeline

Current Behavior

  • Non-blocking: Tests detect and log accessibility violations but don't fail CI

Copilot AI review requested due to automatic review settings July 2, 2025 09:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates a dedicated accessibility (a11y) test suite into the CI pipeline, updates step definitions for more granular selector/context checks, and configures Woodpecker to fail early on accessibility suite failures.

  • Disabled immediate failures on critical accessibility violations (pending resolution)
  • Refactored Cucumber step definition and feature steps to include explicit selector/context parameters
  • Added the a11y suite to the CI configuration in .woodpecker.star

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/e2e/support/utils/accessibility.ts Modified failure logic for critical violations and added a comment
tests/e2e/cucumber/steps/ui/a11.y.ts Renamed and updated step signature to accept selector and context
tests/e2e/cucumber/features/a11y/smoke.feature Updated feature steps to the new step wording
.woodpecker.star Added a11y suite under CI configuration
Comments suppressed due to low confidence (3)

tests/e2e/cucumber/steps/ui/a11.y.ts:6

  • [nitpick] The filename a11.y.ts and step text are ambiguous. Consider renaming the file to a11y.ts or accessibility.ts and simplifying the step to something like '{user} checks accessibility of {selector} in {context}'.
  '{string} checks the accessibility of the DOM selector {string} on the {string}',

tests/e2e/support/utils/accessibility.ts:31

  • The comment indicates enabling test failures later, but the code explicitly disables failures for critical violations. Consider using a config flag or reverting to shouldFail = true so CI can enforce critical a11y checks as intended.
        shouldFail = false

tests/e2e/cucumber/features/a11y/smoke.feature:44

  • This step is repeated many times with only context changes. Consider using a Scenario Outline with Examples or a Background to DRY up the feature.
    And "Alice" checks the accessibility of the DOM selector ".files-view-wrapper" on the "personal space"

@ScharfViktor
Copy link
Contributor Author

Now we have tests in CI https://ci.opencloud.eu/repos/6/pipeline/2469/105, and we can start fixing accessibility issues and, of course, increase test coverage.

@db-ot @kulmann how do you see the next actions?

@db-ot
Copy link

db-ot commented Jul 2, 2025

Creating Bugs from the report and extend the tests regarding A11Y:

  • different Browser and Browser versions ( with some insides we can indicate visitor browser and check the most TOP5 )
  • start testing on shrinked View for Mobil

@ScharfViktor
Copy link
Contributor Author

a11y issue: #889
I will add to it as new errors are discovered.

different browsers: #890
mobile: #891

@kulmann
Copy link
Contributor

kulmann commented Jul 3, 2025

Creating Bugs from the report

Fully agree!

  • different Browser versions

Let's keep it a little simpler and only use the most recent browser versions.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ScharfViktor ScharfViktor merged commit bc1690c into main Jul 3, 2025
21 checks passed
@ScharfViktor ScharfViktor deleted the enableA11yInCi branch July 3, 2025 06:26
@openclouders openclouders mentioned this pull request Jul 2, 2025
1 task
@openclouders openclouders mentioned this pull request Jul 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants