-
Notifications
You must be signed in to change notification settings - Fork 25
enable a11y tests in CI #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates a dedicated accessibility (a11y) test suite into the CI pipeline, updates step definitions for more granular selector/context checks, and configures Woodpecker to fail early on accessibility suite failures.
- Disabled immediate failures on critical accessibility violations (pending resolution)
- Refactored Cucumber step definition and feature steps to include explicit selector/context parameters
- Added the
a11ysuite to the CI configuration in.woodpecker.star
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/support/utils/accessibility.ts | Modified failure logic for critical violations and added a comment |
| tests/e2e/cucumber/steps/ui/a11.y.ts | Renamed and updated step signature to accept selector and context |
| tests/e2e/cucumber/features/a11y/smoke.feature | Updated feature steps to the new step wording |
| .woodpecker.star | Added a11y suite under CI configuration |
Comments suppressed due to low confidence (3)
tests/e2e/cucumber/steps/ui/a11.y.ts:6
- [nitpick] The filename
a11.y.tsand step text are ambiguous. Consider renaming the file toa11y.tsoraccessibility.tsand simplifying the step to something like'{user} checks accessibility of {selector} in {context}'.
'{string} checks the accessibility of the DOM selector {string} on the {string}',
tests/e2e/support/utils/accessibility.ts:31
- The comment indicates enabling test failures later, but the code explicitly disables failures for critical violations. Consider using a config flag or reverting to
shouldFail = trueso CI can enforce critical a11y checks as intended.
shouldFail = false
tests/e2e/cucumber/features/a11y/smoke.feature:44
- This step is repeated many times with only context changes. Consider using a Scenario Outline with Examples or a Background to DRY up the feature.
And "Alice" checks the accessibility of the DOM selector ".files-view-wrapper" on the "personal space"
|
Now we have tests in CI https://ci.opencloud.eu/repos/6/pipeline/2469/105, and we can start fixing accessibility issues and, of course, increase test coverage. |
|
Creating Bugs from the report and extend the tests regarding A11Y:
|
Fully agree!
Let's keep it a little simpler and only use the most recent browser versions. |
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
What Changed:
Current Behavior