-
Notifications
You must be signed in to change notification settings - Fork 25
Expand accessibility testing coverage #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly expands accessibility testing coverage by adding comprehensive accessibility checks across different parts of the application, including new test steps and infrastructure. The changes enhance the existing e2e test framework to enable accessibility validation using automated testing tools.
- Adds comprehensive accessibility testing for file views, admin settings, and UI components
- Introduces new test step definitions and page object methods to support a11y testing
- Refactors existing trashbin navigation logic to be more granular and testable
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/cucumber/features/a11y/smoke.feature | Comprehensive accessibility test scenarios covering files, admin settings, and UI components |
| tests/e2e/cucumber/steps/ui/*.ts | New step definitions for accessibility testing workflows |
| tests/e2e/support/objects/*/actions.ts | New methods for opening panels, menus, and navigation |
| tests/e2e/support/objects/*/index.ts | Updated interfaces to expose new accessibility testing functionality |
| tests/e2e/support/api/davSpaces/*.ts | Added file deletion API support for test cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7c8c604 to
562c729
Compare
57c84f1 to
198d44f
Compare
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
related:
#819
#886
#889
After a full system scan, the test detected:
test output: