Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jun 23, 2025

I splited app-provider pipeline into two:

  • app-provider
  • app-provider-onlyOffice

normal CI running (app-provider is included):

image

[full-ci] running:

Screenshot 2025-06-23 at 15 48 22

@ScharfViktor ScharfViktor added the Type:DevOps Related to CI/CD label Jun 23, 2025
@ScharfViktor ScharfViktor changed the title always run appProvider suite in the CI [full-ci] always run appProvider suite in the CI Jun 23, 2025
@ScharfViktor ScharfViktor marked this pull request as ready for review June 23, 2025 11:53
Copilot AI review requested due to automatic review settings June 23, 2025 11:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR splits the existing app-provider CI pipeline so that the OnlyOffice-specific tests run in their own suite, ensuring the core app-provider suite always executes on every CI run.

  • Removed OnlyOffice settings from the default app-provider suite and introduced a new app-provider-onlyOffice suite
  • Adjusted the skip logic to only bypass the dedicated OnlyOffice suite on non-full-CI, non-cron runs
  • Separated service startup steps in e2eTests for Collabora vs. OnlyOffice
Comments suppressed due to low confidence (2)

.woodpecker.star:109

  • [nitpick] Consider adding a brief comment above this block explaining the purpose and scope of the new app-provider-onlyOffice pipeline for clarity and future maintenance.
        "app-provider-onlyOffice": {

.woodpecker.star:466

  • [nitpick] The suite identifier uses camelCase (app-provider-onlyOffice) which is inconsistent with the kebab-case naming used elsewhere; consider using all lowercase (app-provider-onlyoffice) or aligning naming conventions across suites.
        if "app-provider-onlyOffice" in suite and not "full-ci" in ctx.build.title.lower() and ctx.build.event != "cron":

@ScharfViktor ScharfViktor marked this pull request as draft June 23, 2025 11:57
@ScharfViktor ScharfViktor force-pushed the runAppProviderSuiteAlwaysInCI branch from aae9b39 to d2ea286 Compare June 23, 2025 13:25
@ScharfViktor ScharfViktor changed the title [full-ci] always run appProvider suite in the CI always run appProvider suite in the CI Jun 23, 2025
@ScharfViktor ScharfViktor marked this pull request as ready for review June 23, 2025 13:51
@ScharfViktor ScharfViktor merged commit 0fe283f into main Jun 23, 2025
19 checks passed
@ScharfViktor ScharfViktor deleted the runAppProviderSuiteAlwaysInCI branch June 23, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:DevOps Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants