[full-ci] fix app-provider tests #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken app-provider tests in full-ci by adjusting context menu interactions and updating feature file action labels.
- Uses a hover step on the "Open with..." menu item before selecting the office suite in the support object actions.
- Updates expected action labels in
secureView.featureto match the plain suite names. - Adds a
Givenstep inofficeSuites.featureto create files via API before testing context menu opens.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/actions.ts | Refactors context menu actions to hover "Open with..." before clicking the desired suite. |
| tests/e2e/cucumber/features/app-provider/secureView.feature | Updates expected action names in secure view scenarios. |
| tests/e2e/cucumber/features/app-provider/officeSuites.feature | Introduces API-based file creation step before opening file via context menu. |
Contributor
Author
|
@kulmann I would put |
Contributor
Yes, that's good 👍 |
Contributor
Author
Thank you. I will do it in the next PR |
AlexAndBear
approved these changes
Jun 23, 2025
Contributor
Author
PR for that #845 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #820 and #835
we didn't run in
full-ciso some tests from app-provider were broken. here is fix