feat: space readme loading indicator #408
Conversation
JammingBen
force-pushed
the
feat/space-readme-loading-indicator
branch
from
b1f69c1 to
c621cfc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a loading indicator for space readme content to improve the user experience while the readme is being fetched. Key changes include adding new reactive state and utility functions in the spaces store to track readme loading, and updating the Spaces header component to display a spinner with a retry mechanism for loading readme content.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-pkg/src/composables/piniaStores/spaces.ts | Added reactive state and helper functions (add, remove, purge) for tracking readme loading |
| packages/web-app-files/src/components/Spaces/SpaceHeader.vue | Updated to display a spinner when readme is loading and integrated readme loading management |
|
|
||
| const addToReadmesLoading = (id: string) => { | ||
| if (!unref(readmesLoading).includes(id)) { | ||
| unref(readmesLoading).push(id) |
There was a problem hiding this comment.
Consider replacing 'unref(readmesLoading).push(id)' with 'readmesLoading.value.push(id)' to ensure state updates are tracked consistently by Vue's reactivity system.
| unref(readmesLoading).push(id) | |
| readmesLoading.value.push(id) |
There was a problem hiding this comment.
This is fine since we're pushing into the array, not modifying the variable.
There was a problem hiding this comment.
We have/had a rule though to use .value when writing and unref when reading. I'd also prefer readmesLoading.value.push(id), but just for DX/cosmetic reasons. 😅
There was a problem hiding this comment.
I've always used unref when modifying an array 🙈 Will keep it in mind for the future.
JammingBen
force-pushed
the
feat/space-readme-loading-indicator
branch
from
c621cfc to
24accf2
Compare
JammingBen
force-pushed
the
feat/space-readme-loading-indicator
branch
from
24accf2 to
74e7818
Compare
Similar to #398 but for the space readme.
fixes #361