feat: space image loading indicator #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
feat/space-image-loading-indicator
branch
6 times, most recently
from
66f20e7 to
4cc948f
Compare
JammingBen
force-pushed
the
feat/space-image-loading-indicator
branch
from
4cc948f to
02be523
Compare
JammingBen
commented
Mar 21, 2025
| import { RouteLocationRaw } from 'vue-router' | ||
| export default defineComponent({ | ||
| name: 'AppBar', |
Contributor
Author
There was a problem hiding this comment.
Fyi the names are needed for some components to not end up as an anonymous-stub when used by a component that now uses script setup. This will eventually be obsolete once we refactor those components to script setup as well.
kulmann
approved these changes
Mar 24, 2025
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Cool, thank you! That will make @dragonchaser happy 🤓
packages/web-app-files/tests/unit/components/Spaces/SpaceHeader.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a loading indicator when space images are loading due to:
Also refactors to script setup:
Projects.vue,SpaceHeader.vue,SpaceDetails.vuerefs #361