Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 19, 2025

Description

image

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear marked this pull request as ready for review November 19, 2025 12:29
Copilot AI review requested due to automatic review settings November 19, 2025 12:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements dynamic icon selection for the empty trash bin action, showing an empty trash bin icon when the trash is empty and a filled trash bin icon when it contains items. The implementation extends the Action interface to support icons as functions that can dynamically determine the appropriate icon based on context.

Key Changes:

  • Extended the Action interface to allow icon to be either a string or a function that returns a string
  • Implemented dynamic icon selection in the empty trash bin action based on the hasTrashedItems property
  • Updated all components that render action icons to handle both static and function-based icons

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/web-pkg/src/composables/actions/types.ts Extended Action interface to support function-based icons
packages/web-pkg/src/composables/actions/files/useFileActionsEmptyTrashBin.ts Implemented dynamic icon selection for empty trash bin action
packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue Added computed property to resolve action icons
packages/web-app-files/src/views/spaces/GenericTrash.vue Added icon resolution for trash bin action button
packages/web-app-files/src/components/Trash/TrashQuickActions.vue Added helper function to resolve action icons
packages/web-app-files/src/components/FilesList/QuickActions.vue Added helper function to resolve action icons
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue Added helper function to resolve action icons
packages/web-app-admin-settings/src/views/Users.vue Added computed property to resolve create user action icon
packages/web-app-admin-settings/src/views/Groups.vue Added computed property to resolve create group action icon

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AlexAndBear and others added 3 commits November 19, 2025 14:12
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like a charm and really achieves better visual guidance. 💪

@AlexAndBear AlexAndBear merged commit 2738a26 into main Nov 25, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the issues/1637 branch November 25, 2025 08:07
@openclouders openclouders mentioned this pull request Nov 25, 2025
1 task
@openclouders openclouders mentioned this pull request Dec 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change trash bin icon in overview

4 participants