fix: add missing drag styling in tiles view #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing drag styling for the tiles view while standardizing drag-and-drop behavior across both tile and table views. The changes refactor drag-and-drop logic into a shared composable to ensure consistent behavior.
Key changes:
- Extracted drag-and-drop functionality into a new shared composable
useResourceViewDrag - Updated
OcTablecomponent to pass item objects instead of DOM selectors in drag events - Applied consistent drag styling using
data-item-idattributes across both views
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-pkg/src/composables/resources/useResourceViewHelpers.ts |
Integrated drag functionality and exposed helper methods for resource selection |
packages/web-pkg/src/composables/resources/useResourceViewDrag.ts |
New composable containing shared drag-and-drop logic for both tile and table views |
packages/web-pkg/src/composables/resources/index.ts |
Exported the new drag composable |
packages/web-pkg/src/components/FilesList/ResourceTiles.vue |
Removed duplicated drag logic in favor of shared composable |
packages/web-pkg/src/components/FilesList/ResourceTable.vue |
Removed duplicated drag logic and updated to use shared composable |
packages/design-system/src/components/OcTable/OcTable.vue |
Changed event signatures to pass item objects instead of selectors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
force-pushed
the
fix/tiles-view-drag-highlight
branch
from
7924fe6 to
e3c3a6a
Compare
While also aligning the drag&drop-behavior for both the tile and table view.
JammingBen
force-pushed
the
fix/tiles-view-drag-highlight
branch
from
e3c3a6a to
db4dfa3
Compare
kulmann
approved these changes
Dec 5, 2025
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
works like a charm, nice!
openclouders
pushed a commit
that referenced
this pull request
Dec 5, 2025
fix: add missing drag styling in tiles view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While also aligning the drag&drop-behavior for both the tile and table view.
fixes #1638
part of #1518