fix: prevent undo delete multiple times for same file #1587
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the undo delete action could be triggered multiple times for the same file - once via the notification button and again via the Ctrl/Cmd+Z keyboard shortcut, potentially causing unintended behavior.
Key changes:
- Move
keyActionIddeclaration outside the conditional block to make it accessible in the callback scope - Add cleanup logic to remove the keyboard action when the undo action is triggered via the notification button
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-pkg/src/composables/actions/helpers/useFileActionsDeleteResources.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/helpers/useFileActionsDeleteResources.ts
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/undo-delete-twice
branch
from
c5afe7c to
8484e3d
Compare
AlexAndBear
approved these changes
Nov 11, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
openclouders
pushed a commit
that referenced
this pull request
Nov 11, 2025
fix: prevent undo delete multiple times for same file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen when undoing a delete via the notification and then clicking ctrl/cmd + z.
Fixes what has been reported in PR #1580.