Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Nov 10, 2025

test for feature #1357

  • undo deleted files in the personal and project spaces
  • by pressing undo button or cmd+z
  • check restoring single file, multiple files

Notice:
@JammingBen seems like bug

steps:

  • delete file
  • restore by press undo button
  • press cmd+z

Actual:
image

web tries to restore file again but fails when keep both is selected
image

Copilot AI review requested due to automatic review settings November 10, 2025 19:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds end-to-end tests for feature #1357, which allows users to undo deleted resources in both personal and project spaces. The tests verify that files can be restored using either the "undo" button or the keyboard shortcut (Cmd+Z/Ctrl+Z).

Key changes:

  • Removed page navigation after deletion to maintain undo button visibility
  • Added new undoLastDeletedResource method to handle restoration via button or keyboard
  • Created comprehensive test scenarios covering single file, multiple files, and sequential undo operations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
tests/e2e/support/objects/app-files/resource/index.ts Removed page reload after deletion; added wrapper method for undo functionality
tests/e2e/support/objects/app-files/resource/actions.ts Implemented core undo logic with response waiting and dual input methods
tests/e2e/cucumber/steps/ui/resources.ts Added Cucumber step definition for undo deletion action
tests/e2e/cucumber/features/file-action/delete.feature Added comprehensive test scenario covering personal and project space undo operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JammingBen
Copy link
Contributor

Notice: @JammingBen seems like bug

steps:

  • delete file
  • restore by press undo button
  • press cmd+z

Yep good catch, I'm gonna take care today.

CI fails across the board, not sure if related though 🤔

@ScharfViktor
Copy link
Contributor Author

Yep good catch, I'm gonna take care today.

👍

CI fails across the board, not sure if related though 🤔

I deleted await this.#page.goto(startUrl) after delete resource step. it's reason why ci is fail

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor ScharfViktor merged commit ab54fc7 into main Nov 11, 2025
28 checks passed
@ScharfViktor ScharfViktor deleted the undoDeletedResources branch November 11, 2025 14:46
openclouders pushed a commit that referenced this pull request Nov 11, 2025
@openclouders openclouders mentioned this pull request Nov 11, 2025
1 task
ScharfViktor added a commit that referenced this pull request Dec 3, 2025
@ScharfViktor
Copy link
Contributor Author

💔 Some backports could not be created

Status Branch Result
stable-2.1 Conflict resolution was aborted by the user
stable-4.2

Manual backport

To create the backport manually run:

backport --pr 1580

Questions ?

Please refer to the Backport tool documentation

ScharfViktor added a commit that referenced this pull request Dec 11, 2025
This was referenced Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants