-
Notifications
You must be signed in to change notification settings - Fork 25
e2e-tests. undo deleted resources #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds end-to-end tests for feature #1357, which allows users to undo deleted resources in both personal and project spaces. The tests verify that files can be restored using either the "undo" button or the keyboard shortcut (Cmd+Z/Ctrl+Z).
Key changes:
- Removed page navigation after deletion to maintain undo button visibility
- Added new
undoLastDeletedResourcemethod to handle restoration via button or keyboard - Created comprehensive test scenarios covering single file, multiple files, and sequential undo operations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/index.ts | Removed page reload after deletion; added wrapper method for undo functionality |
| tests/e2e/support/objects/app-files/resource/actions.ts | Implemented core undo logic with response waiting and dual input methods |
| tests/e2e/cucumber/steps/ui/resources.ts | Added Cucumber step definition for undo deletion action |
| tests/e2e/cucumber/features/file-action/delete.feature | Added comprehensive test scenario covering personal and project space undo operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yep good catch, I'm gonna take care today. CI fails across the board, not sure if related though 🤔 |
👍
I deleted |
b870af8 to
9ac1a0c
Compare
|
(cherry picked from commit ab54fc7)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
test for feature #1357
undobutton orcmd+zNotice:
@JammingBen seems like bug
steps:
undobuttonActual:

web tries to restore file again but fails when

keep bothis selected