fix: version downloads and remove downloadUrl dav property default #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
commented
Nov 7, 2025
Comment on lines
338
to
345
| callbackFn: async ({ resource }: { resource: Resource }) => { | ||
| const { downloadURL: url } = await webdav.getFileInfo(space, resource, { | ||
| davProperties: [DavProperty.FileId, DavProperty.DownloadURL] | ||
| }) | ||
| postMessageToCollabora('Action_InsertGraphic', { url }) |
Contributor
Author
There was a problem hiding this comment.
Obviously I can't test this, but making this callback async shouldn't be an issue.
Contributor
Author
|
|
JammingBen
force-pushed
the
fix/download-url-prop
branch
from
98bfc0d to
730826b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes WebDAV performance by removing downloadURL from the default DAV properties, fetching it on-demand instead (except for public links where it's needed for previews). Additionally, it removes deprecated avatar URL caching logic.
Key Changes:
- Removed
downloadURLfrom default DAV properties and added on-demand fetching - Removed deprecated avatar URL helper functions and associated tests
- Fixed version download URL handling with required username validation
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-client/src/webdav/constants/dav.ts | Removed DownloadURL from default DAV properties |
| packages/web-client/src/webdav/getFileUrl.ts | Refactored to fetch downloadURL on-demand and added username validation for version URLs |
| packages/web-client/src/webdav/index.ts | Added getFileInfoFactory parameter to GetFileUrlFactory |
| packages/web-client/src/webdav/listFiles.ts | Added null check for fileId to prevent comparison errors |
| packages/web-pkg/src/services/folder/loaders/loaderSpace.ts | Added downloadURL to DAV properties for public links to support previews |
| packages/web-pkg/src/services/preview/previewService.ts | Added on-demand downloadURL fetching when not present |
| packages/web-pkg/src/services/cache.ts | Marked avatarUrl getter as deprecated |
| packages/web-pkg/tests/unit/services/cache.spec.ts | Removed avatarUrl cache test |
| packages/web-app-files/src/helpers/user/avatarUrl.ts | Removed entire avatarUrl helper implementation |
| packages/web-app-files/tests/unit/helpers/user/avatarUrl.spec.ts | Removed avatarUrl tests |
| packages/web-app-files/src/helpers/user/index.ts | Removed export statement |
| packages/web-app-external/src/App.vue | Added on-demand downloadURL fetching for Collabora image insertion |
| .woodpecker.env | Updated OpenCloud commit ID |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also removes the `downloadURL` prop from the default requested DAV properties for performance reasons. This property gets requested on demand now (with public links being an exception so we can show previews).
JammingBen
force-pushed
the
fix/download-url-prop
branch
from
730826b to
7e857b6
Compare
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
openclouders
pushed a commit
that referenced
this pull request
Nov 17, 2025
fix: version downloads and remove downloadUrl dav property default
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version downloads and removes the
downloadURLprop from the default requested DAV properties for performance reasons. This property gets requested on demand now (with public links being an exception so we can show previews).And removes some ancient avatar URL logic (see opencloud-eu/opencloud#1197 (comment)).
fixes #1521