fix: space batch actions not loading in spaces table #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ResourceTable.vue component from Options API to Composition API (script setup) and removes deprecated functionality from useResourceRouteResolver. The main changes include:
- Converting ResourceTable from Options API to Composition API using
<script setup> - Deprecating the
contextparameter andcreateFileActionmethod inuseResourceRouteResolver - Removing usage of deprecated
createFileActionin favor of directly emittingfileClickevents - Replacing
useResourceRouteResolverwithuseFolderLinkin ResourceTiles - Removing unused slot documentation comments
- Adding proper TypeScript type imports for
FileActionOptions - Standardizing selection handling to use
resourcesStore.toggleSelection()
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ResourceTiles.spec.ts | Adds import for useResourcesStore and pre-sets selection state in test to match new store-based selection handling |
| useResourceRouteResolver.ts | Marks the context parameter and createFileAction method as deprecated |
| ResourceTiles.vue | Refactors to use useFolderLink instead of useResourceRouteResolver, emits fileClick directly, and uses resourcesStore.toggleSelection() |
| ResourceTable.vue | Major refactor from Options API to Composition API with script setup, including props/emits/slots definitions and function conversions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
force-pushed
the
fix/space-batch-actions-not-loading
branch
from
2cf1fc0 to
25a57d5
Compare
AlexAndBear
approved these changes
Nov 5, 2025
openclouders
pushed a commit
that referenced
this pull request
Nov 5, 2025
…t-loading fix: space batch actions not loading in spaces table
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And refactors the
ResourceTablecomponent to script setup. This was long overdue since it was partly options API still. Also deprecatescreateFileActionofuseResourceRouteResolver. Feels misplaced there and we already haveuseFileActions.Check commits for an easier review.
fixes #1499
refs #1462