fix: bottom drawer 'New'-menus appearance #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates CSS styling for improved responsive design in the file upload and creation interface. The changes focus on adding responsive breakpoints (sm:) to various CSS classes and adjusting icon sizing for mobile and desktop views.
Key Changes:
- Added responsive breakpoints (
sm:) to padding and minimum width utilities for better mobile display - Updated icon sizing to use mobile-first approach with SVG-specific height classes
- Replaced
left-[99999px]withhiddenclass for hiding file input elements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web-app-files/src/components/AppBar/CreateAndUpload.vue | Updated CSS classes with responsive breakpoints for list padding, minimum width, and icon sizing |
| packages/web-app-files/src/components/AppBar/Upload/ResourceUpload.vue | Modified icon sizing classes and changed hidden input positioning from left-[99999px] to hidden |
| packages/web-app-files/tests/unit/components/AppBar/snapshots/CreateAndUpload.spec.ts.snap | Updated snapshot to reflect CSS class changes in CreateAndUpload component |
| packages/web-app-files/tests/unit/components/AppBar/Upload/snapshots/ResourceUpload.spec.ts.snap | Updated snapshot to reflect CSS class changes in ResourceUpload component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-app-files/src/components/AppBar/Upload/ResourceUpload.vue
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/bottom-drawer-new-file-styling
branch
2 times, most recently
from
da6743c to
5bd6c04
Compare
JammingBen
force-pushed
the
fix/bottom-drawer-new-file-styling
branch
from
5bd6c04 to
e24d1b2
Compare
AlexAndBear
approved these changes
Nov 4, 2025
openclouders
pushed a commit
that referenced
this pull request
Nov 5, 2025
…-styling fix: bottom drawer 'New'-menus appearance
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
[&_svg]:h-5.5!on theResourceIconcomponent are unfortunately necessary for the icons to appear in their correct size in the "New"-menu. The sizing of this component is a complete mess, should be fixed at some point...fixes #1446