Introduce mail app #1382
Merged
Introduce mail app #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammi-23
added
Type:Maintenance
AlexAndBear
reviewed
Oct 17, 2025
AlexAndBear
force-pushed
the
feat/groupware1
branch
from
1cf0776 to
a51cdd0
Compare
AlexAndBear
reviewed
Oct 29, 2025
AlexAndBear
force-pushed
the
feat/groupware1
branch
from
cb69934 to
0d24e32
Compare
AlexAndBear
requested review from
AlexAndBear,
JammingBen and
kulmann
and removed request for
AlexAndBear
JammingBen
reviewed
Nov 4, 2025
Contributor
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Just a code-review for now, I didn't test anything yet.
And I see a lot of @opencloud-eu/web-pkg/src imports 😬 Can IntelliJ somehow be trained not to do that? While it works here (because the package lives in the monorepo) it's technically not quite correct.
| @@ -0,0 +1,92 @@ | |||
| <template> | |||
| <div class="mail-attachment-item flex justify-between items-center"> | |||
Contributor
There was a problem hiding this comment.
Hmm I often see classes on elements like here e.g. mail-attachment-item. Do you need them? One of the advantages with Tailwind is that you don't need custom css class names anymore since they just bloat the DOM.
Contributor
There was a problem hiding this comment.
I am not quite sure yet, it may help with e2e tests 🤔
# Conflicts: # pnpm-lock.yaml
AlexAndBear
force-pushed
the
feat/groupware1
branch
from
e66952c to
d8ba35f
Compare
tammi-23
added
Type:Feature-Request
and removed
Type:Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1250
Fixes #1244
Fixes #1292
Fixes #1293
Fixes #1269
Fixes #1270
Fixes #1426
Fixes #1299
Fixes #1481
Fixes #1476