Skip to content

fail accessibility tests on any violation #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScharfViktor merged 1 commit into from
Oct 7, 2025
Merged

fail accessibility tests on any violation #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .woodpecker.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# The version of OpenCloud to use in pipelines
OPENCLOUD_COMMITID=cd33119f65a4a7591471c516ffd6a4c6f2874316
OPENCLOUD_COMMITID=9ec532da93f2401459c8d17594590edfba08af12
OPENCLOUD_BRANCH=main
1 change: 0 additions & 1 deletion .woodpecker.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ config = {
"NATS_NATS_HOST": "0.0.0.0",
"NATS_NATS_PORT": 9233,
"COLLABORA_DOMAIN": "collabora:9980",
"FRONTEND_APP_HANDLER_SECURE_VIEW_APP_ADDR": "eu.opencloud.api.collaboration.Collabora",
"WEB_UI_CONFIG_FILE": None,
},
},
Expand Down
1 change: 0 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ services:
MICRO_REGISTRY_ADDRESS: 0.0.0.0:9233
PROXY_CSP_CONFIG_FILE_LOCATION: /etc/opencloud/csp.yaml
COLLABORA_DOMAIN: host.docker.internal:9980
FRONTEND_APP_HANDLER_SECURE_VIEW_APP_ADDR: eu.opencloud.api.collaboration.Collabora
# Needed for enabling all roles
GRAPH_AVAILABLE_ROLES: b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5,a8d5fe5e-96e3-418d-825b-534dbdf22b99,fb6c3e19-e378-47e5-b277-9732f9de6e21,58c63c02-1d89-4572-916a-870abc5a1b7d,2d00ce52-1fc2-4dbc-8b95-a73b73395f5a,1c996275-f1c9-4e71-abdf-a42f6495e960,312c0871-5ef7-4b3a-85b6-0e4074c64049,aa97fe03-7980-45ac-9e50-b325749fd7e6,63e64e19-8d43-42ec-a738-2b6af2610efa
labels:
Expand Down
16 changes: 1 addition & 15 deletions tests/e2e/support/utils/accessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export async function checkAccessibility(
builder = builder.include(includeSelector)
}
const results = await builder.analyze()
let shouldFail = false

if (results.violations.length > 0) {
console.error(`♿ Accessibility violations detected${context ? ` in ${context}` : ''}:`)
Expand All @@ -25,20 +24,7 @@ export async function checkAccessibility(
violation.nodes.forEach((node, idx) => {
console.error(` Node ${idx + 1}: ${node.html}`)
})

if (violation.impact === 'critical') {
// Enable test failure after critical availability issue is resolved
shouldFail = false
}
}
console.log(
`Accessibility check failed with ${results.violations.length} violation(s)${context ? ` in ${context}` : ''}.`
)

if (shouldFail) {
throw new Error(
`Accessibility check failed due to critical or serious violation(s)${context ? ` in ${context}` : ''}.`
)
}
throw new Error(`Accessibility check failed${context ? ` in ${context}` : ''}.`)
}
}