Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

Now that we fixed all a11y issues (see #889), I switched the test to fail if new a11y issues appear.

Copilot AI review requested due to automatic review settings October 6, 2025 13:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the accessibility testing behavior to fail on any accessibility violation rather than only on critical violations. Previously, the test would only fail for critical accessibility issues, but now it will fail immediately when any violation is detected.

  • Removed conditional logic that only failed tests on critical accessibility violations
  • Simplified error handling to throw an error for any accessibility violation
  • Updated OpenCloud commit ID reference

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/e2e/support/utils/accessibility.ts Simplified accessibility checking to fail on any violation instead of only critical ones
.woodpecker.env Updated OpenCloud commit ID reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ScharfViktor
Copy link
Contributor Author

app-provider/secureView.feature does not work because the user cannot open a shared file with the secure view role.
This started happening after updating OpenCloud.

secure view role:
Screenshot 2025-10-07 at 11 36 05

view role:
Screenshot 2025-10-07 at 11 35 40

@JammingBen
Copy link
Contributor

Good catch. It seems to be set to false from the server:

image

@ScharfViktor
Copy link
Contributor Author

@micbar suggested to delete FRONTEND_APP_HANDLER_SECURE_VIEW_APP_ADDR env from setup

now locally works fine. waiting CI

Screenshot 2025-10-07 at 11 56 07

@ScharfViktor ScharfViktor force-pushed the fix/a11y-fail-on-any-violation branch from d059fdf to d4f21b6 Compare October 7, 2025 10:04
@ScharfViktor ScharfViktor merged commit b84319e into main Oct 7, 2025
28 checks passed
@ScharfViktor ScharfViktor deleted the fix/a11y-fail-on-any-violation branch October 7, 2025 10:20
@openclouders openclouders mentioned this pull request Oct 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants