-
Notifications
You must be signed in to change notification settings - Fork 25
fail accessibility tests on any violation #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the accessibility testing behavior to fail on any accessibility violation rather than only on critical violations. Previously, the test would only fail for critical accessibility issues, but now it will fail immediately when any violation is detected.
- Removed conditional logic that only failed tests on critical accessibility violations
- Simplified error handling to throw an error for any accessibility violation
- Updated OpenCloud commit ID reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/support/utils/accessibility.ts | Simplified accessibility checking to fail on any violation instead of only critical ones |
| .woodpecker.env | Updated OpenCloud commit ID reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@micbar suggested to delete now locally works fine. waiting CI
|
d059fdf to
d4f21b6
Compare




Now that we fixed all a11y issues (see #889), I switched the test to fail if new a11y issues appear.