-
Notifications
You must be signed in to change notification settings - Fork 25
feat: tiles view for trash #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds tiles view support for trash content by enabling folder view modes in the trash interface. The changes allow users to switch between different view modes (table, tiles, etc.) when browsing deleted files in the trash, providing a more flexible viewing experience.
- Introduces a new trash extension point for folder views
- Adds view mode switching capabilities to the trash interface
- Updates existing folder view extensions to support trash contexts
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Adds areResourcesClickable prop to control clickability of resources in tiles view |
| packages/web-app-files/src/views/spaces/GenericTrash.vue | Replaces hardcoded ResourceTable with dynamic component selection based on view mode |
| packages/web-app-files/src/extensionPoints.ts | Defines new trash extension point for folder views |
| packages/web-app-files/src/composables/extensions/useFolderViews.ts | Updates existing folder view extensions to include trash extension point |
| packages/web-app-files/tests/unit/views/spaces/GenericTrash.spec.ts | Updates test to mock extension registry and folder view extensions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eeed01a to
177bc02
Compare
# Conflicts: # packages/web-app-files/src/composables/extensions/useFolderViews.ts
e280f5b to
486ba4b
Compare
a75266c to
8b77af5
Compare
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Description
Related Issue
How Has This Been Tested?
Types of changes