Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Oct 2, 2025

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear marked this pull request as ready for review October 2, 2025 18:51
@AlexAndBear AlexAndBear requested review from Copilot and kulmann October 2, 2025 18:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tiles view support for trash content by enabling folder view modes in the trash interface. The changes allow users to switch between different view modes (table, tiles, etc.) when browsing deleted files in the trash, providing a more flexible viewing experience.

  • Introduces a new trash extension point for folder views
  • Adds view mode switching capabilities to the trash interface
  • Updates existing folder view extensions to support trash contexts

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/web-pkg/src/components/FilesList/ResourceTiles.vue Adds areResourcesClickable prop to control clickability of resources in tiles view
packages/web-app-files/src/views/spaces/GenericTrash.vue Replaces hardcoded ResourceTable with dynamic component selection based on view mode
packages/web-app-files/src/extensionPoints.ts Defines new trash extension point for folder views
packages/web-app-files/src/composables/extensions/useFolderViews.ts Updates existing folder view extensions to include trash extension point
packages/web-app-files/tests/unit/views/spaces/GenericTrash.spec.ts Updates test to mock extension registry and folder view extensions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexAndBear AlexAndBear removed the request for review from kulmann October 2, 2025 21:27
@AlexAndBear AlexAndBear marked this pull request as draft October 2, 2025 21:27
@AlexAndBear AlexAndBear changed the title feat: tiles view for trash content feat: tiles view for trash Oct 2, 2025
@AlexAndBear AlexAndBear force-pushed the generic-trash-support-tiles-view branch from eeed01a to 177bc02 Compare October 2, 2025 21:32
# Conflicts:
#	packages/web-app-files/src/composables/extensions/useFolderViews.ts
@AlexAndBear AlexAndBear force-pushed the generic-trash-support-tiles-view branch from e280f5b to 486ba4b Compare October 6, 2025 07:28
@AlexAndBear AlexAndBear force-pushed the generic-trash-support-tiles-view branch from a75266c to 8b77af5 Compare October 6, 2025 09:58
@AlexAndBear AlexAndBear requested a review from kulmann October 6, 2025 11:00
@AlexAndBear AlexAndBear marked this pull request as ready for review October 6, 2025 11:00
AlexAndBear and others added 3 commits October 7, 2025 19:30
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@AlexAndBear AlexAndBear requested a review from JammingBen October 8, 2025 07:53
@AlexAndBear AlexAndBear merged commit f7ab57c into main Oct 8, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the generic-trash-support-tiles-view branch October 8, 2025 08:12
@openclouders openclouders mentioned this pull request Oct 8, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants