fix: authenticated requests in password protected public links #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes authentication handling for password-protected public links by refactoring the makeRequest method to use the Auth service instead of manual header construction. This ensures that authenticated users in a password-protected public link context use the password for authentication rather than the Bearer token.
Key changes:
- Replaced manual authentication header construction with the
Authservice - Updated HTTP client selection logic to consider public link context
- Simplified authentication flow by delegating header management to the
Authclass
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
fix/authenticated-requests-public-link
branch
2 times, most recently
from
6df755a to
e9f7919
Compare
kulmann
reviewed
Sep 22, 2025
As authenticated user in a password protected public link context, the `makeRequest` method of the `useRequest` composable should use the password for authentication instead of the Bearer token.
JammingBen
force-pushed
the
fix/authenticated-requests-public-link
branch
from
e9f7919 to
663235e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As authenticated user in a password protected public link context, the
makeRequestmethod of theuseRequestcomposable should use the password for authentication instead of the Bearer token.refs opencloud-eu/opencloud#1517