e2e. view mode switch #1177
Merged
e2e. view mode switch #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
force-pushed
the
viewModeSwitch
branch
from
2c395ec to
3ba1a8a
Compare
Contributor
Author
|
@AlexAndBear sorry for late finding fixed it here |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements end-to-end test support for view mode switching functionality, enhancing the test infrastructure to handle different view modes (table, tiles, table-condensed) across both desktop and mobile browsers.
- Refactored view mode switching logic to support both desktop and mobile interfaces
- Updated test step definitions to use more consistent naming conventions
- Modified feature files to use the new standardized view mode terminology
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/index.ts | Removed specific tiles view methods, added generic view mode handling |
| tests/e2e/support/objects/app-files/resource/actions.ts | Enhanced view mode switching with mobile browser support and unified view mode validation |
| tests/e2e/cucumber/steps/ui/resources.ts | Updated step definitions to use consistent view mode terminology |
| tests/e2e/cucumber/features/user-settings/tiles.feature | Updated to use new view mode step syntax |
| tests/e2e/cucumber/features/smoke/tags.feature | Updated view mode references to use new terminology |
| tests/e2e/cucumber/features/shares/denyShareAccess.feature | Updated view mode references to use new terminology |
| tests/e2e/cucumber/features/mobile-view/smoke.feature | Added view mode switching tests for mobile scenarios |
| tests/e2e/cucumber/features/a11y/smoke.feature | Updated accessibility tests to use new view mode syntax |
| packages/web-app-files/src/composables/extensions/useFolderViews.ts | Updated UI labels for view mode options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
reviewed
Sep 15, 2025
packages/web-app-files/src/composables/extensions/useFolderViews.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting until #1159 will merged