Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 8, 2025

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear force-pushed the tiles-default-view branch 2 times, most recently from a887736 to 5605def Compare September 9, 2025 15:36
@AlexAndBear AlexAndBear force-pushed the tiles-default-view branch 2 times, most recently from 602324b to c602220 Compare September 9, 2025 21:49
@ScharfViktor
Copy link
Contributor

@AlexAndBear I fixed this step

And "Alice" copies the following resource using keyboard                                   # file:/Users/v.scharf/Work/opencloud/web/tests/e2e/cucumber/steps/ui/resources.ts:95
        | resource            | to          |
        | KeyboardExample.txt | PARENTCopy3 |

but next step is failed

✘ And "Alice" moves the following resource using drag-drop                                   # file:/Users/v.scharf/Work/opencloud/web/tests/e2e/cucumber/steps/ui/resources.ts:95
       | resource     | to          |
       | dragDrop.txt | PARENTCopy2 |

it seems that we cannot move file to folder using drag-drop. (moving folder to folder works)

@ScharfViktor
Copy link
Contributor

Screen.Recording.2025-09-10.at.12.03.12.mp4

@AlexAndBear
Copy link
Contributor Author

@AlexAndBear I fixed this step

And "Alice" copies the following resource using keyboard                                   # file:/Users/v.scharf/Work/opencloud/web/tests/e2e/cucumber/steps/ui/resources.ts:95
        | resource            | to          |
        | KeyboardExample.txt | PARENTCopy3 |

but next step is failed

✘ And "Alice" moves the following resource using drag-drop                                   # file:/Users/v.scharf/Work/opencloud/web/tests/e2e/cucumber/steps/ui/resources.ts:95
       | resource     | to          |
       | dragDrop.txt | PARENTCopy2 |

it seems that we cannot move file to folder using drag-drop. (moving folder to folder works)

It looks like that this issue only applies to files that have a preview, moving e.G PDF files (which doesn't have a preview) do work

@AlexAndBear
Copy link
Contributor Author

@AlexAndBear I fixed this step

And "Alice" copies the following resource using keyboard                                   # file:/Users/v.scharf/Work/opencloud/web/tests/e2e/cucumber/steps/ui/resources.ts:95
        | resource            | to          |
        | KeyboardExample.txt | PARENTCopy3 |

but next step is failed

✘ And "Alice" moves the following resource using drag-drop                                   # file:/Users/v.scharf/Work/opencloud/web/tests/e2e/cucumber/steps/ui/resources.ts:95
       | resource     | to          |
       | dragDrop.txt | PARENTCopy2 |

it seems that we cannot move file to folder using drag-drop. (moving folder to folder works)

fixed

})
// Disable lazy loading during E2E tests to avoid having to scroll in tests
const areTilesLazy = (window as any).__E2E__ === true ? false : lazy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@AlexAndBear AlexAndBear marked this pull request as ready for review September 10, 2025 14:30
Copilot AI review requested due to automatic review settings September 10, 2025 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets the tiles view as the default view option for the files interface, replacing the previous table view default. The change implements a UX improvement by making the more visual tiles view the primary interface for browsing files and folders.

  • Changes the default view mode from "resource-table" to "resource-tiles"
  • Updates E2E test selectors to handle both table and tiles view modes
  • Adds functionality to reduce tile size and disable lazy loading during tests

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/web-pkg/src/composables/viewMode/constants.ts Changes default view mode from table to tiles
packages/web-pkg/src/components/AppBar/AppBar.vue Updates default prop to use new constant
packages/web-app-files/src/views/spaces/Projects.vue Uses new default constant instead of hardcoded tiles mode
packages/web-pkg/src/components/FilesList/ResourceTiles.vue Adds test attributes and disables lazy loading for E2E tests
packages/web-pkg/src/components/FilesList/ResourceTile.vue Adds test attributes to thumbnail images
packages/web-pkg/src/components/FilesList/ResourceTable.vue Adds test attributes to checkboxes
packages/web-pkg/src/components/FilesList/ResourceListItem.vue Adds test attributes to thumbnails
packages/web-pkg/src/components/ContextActions/ContextMenuQuickAction.vue Adds test attribute for context menu identification
tests/e2e/support/objects/app-files/utils/sidebar.ts Updates selector to work with both view modes
tests/e2e/support/objects/app-files/resource/utils.ts Updates resource name selector for both view modes
tests/e2e/support/objects/app-files/resource/actions.ts Updates selectors and adds tile size reduction functionality
tests/e2e/support/environment/actor/actor.ts Adds E2E test flag to window object
Multiple test feature files Adds explicit table view switching for tests that require it
Multiple snapshot files Updates snapshots to reflect new default view mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ScharfViktor
Copy link
Contributor

@AlexAndBear we have only mobile failed test. Here is fix #1173
please rebase after merging

AlexAndBear and others added 7 commits September 11, 2025 13:31
@AlexAndBear AlexAndBear merged commit ea3bd9a into main Sep 12, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the tiles-default-view branch September 12, 2025 11:15
openclouders pushed a commit that referenced this pull request Sep 12, 2025
Co-authored-by: Viktor Scharf <scharf.vi@gmail.com>
@openclouders openclouders mentioned this pull request Sep 12, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make tiles view default across the web ui

4 participants