-
Notifications
You must be signed in to change notification settings - Fork 25
feat: set tiles view as default view option #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3aaa63 to
21e35ee
Compare
a887736 to
5605def
Compare
602324b to
c602220
Compare
|
@AlexAndBear I fixed this step but next step is failed it seems that we cannot move file to folder using drag-drop. (moving folder to folder works) |
Screen.Recording.2025-09-10.at.12.03.12.mp4 |
It looks like that this issue only applies to files that have a preview, moving e.G PDF files (which doesn't have a preview) do work |
fixed |
| }) | ||
| // Disable lazy loading during E2E tests to avoid having to scroll in tests | ||
| const areTilesLazy = (window as any).__E2E__ === true ? false : lazy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets the tiles view as the default view option for the files interface, replacing the previous table view default. The change implements a UX improvement by making the more visual tiles view the primary interface for browsing files and folders.
- Changes the default view mode from "resource-table" to "resource-tiles"
- Updates E2E test selectors to handle both table and tiles view modes
- Adds functionality to reduce tile size and disable lazy loading during tests
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/composables/viewMode/constants.ts | Changes default view mode from table to tiles |
| packages/web-pkg/src/components/AppBar/AppBar.vue | Updates default prop to use new constant |
| packages/web-app-files/src/views/spaces/Projects.vue | Uses new default constant instead of hardcoded tiles mode |
| packages/web-pkg/src/components/FilesList/ResourceTiles.vue | Adds test attributes and disables lazy loading for E2E tests |
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Adds test attributes to thumbnail images |
| packages/web-pkg/src/components/FilesList/ResourceTable.vue | Adds test attributes to checkboxes |
| packages/web-pkg/src/components/FilesList/ResourceListItem.vue | Adds test attributes to thumbnails |
| packages/web-pkg/src/components/ContextActions/ContextMenuQuickAction.vue | Adds test attribute for context menu identification |
| tests/e2e/support/objects/app-files/utils/sidebar.ts | Updates selector to work with both view modes |
| tests/e2e/support/objects/app-files/resource/utils.ts | Updates resource name selector for both view modes |
| tests/e2e/support/objects/app-files/resource/actions.ts | Updates selectors and adds tile size reduction functionality |
| tests/e2e/support/environment/actor/actor.ts | Adds E2E test flag to window object |
| Multiple test feature files | Adds explicit table view switching for tests that require it |
| Multiple snapshot files | Updates snapshots to reflect new default view mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@AlexAndBear we have only mobile failed test. Here is fix #1173 |
fc4036b to
e5226c2
Compare
# Conflicts: # tests/e2e/cucumber/steps/ui/resources.ts # tests/e2e/support/objects/app-files/resource/actions.ts # tests/e2e/support/objects/app-files/resource/index.ts
e5226c2 to
cc11d6e
Compare
…g manually to table view in e2e tests
Co-authored-by: Viktor Scharf <scharf.vi@gmail.com>
Description
Related Issue
How Has This Been Tested?
Types of changes