fix metadata locking #411
Merged
fix metadata locking #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
hm, we should at least delete the mlock file when deleting the file 🤔 |
1 task
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
fix-metadata-locking
branch
from
a0bfab3 to
be86d8b
Compare
Author
|
Leaving opencloud-eu/opencloud#1827 as a followup issue |
Author
|
…h items Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
fix-metadata-locking
branch
from
7196109 to
beb7cab
Compare
rhafer
approved these changes
Nov 11, 2025
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
approved these changes
Nov 12, 2025
github-project-automation
bot
moved this from In Progress
to Done
in OpenCloud Team Board
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes opencloud-eu/opencloud#1793
This will leave empty mlock files on disk. We MUST NOT delete them, or the inode might change, which will allow more than one goroutine to "lock" the file, because file handles used by FLOCK underneath use the inode.
We need to find another solution if we want to keep the disk tidy. For now, the mlock files have to stay. In posix we have moved them to a metadata folder so they do not clutter the normal files.