-
Notifications
You must be signed in to change notification settings - Fork 157
enhancement(search): simplify search docs and document opensearch backend #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(search): simplify search docs and document opensearch backend #1513
Conversation
0782c9e to
a1a9d67
Compare
aduffeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks/suggestions. lgtm in general.
Co-authored-by: Andre Duffeck <aduffeck@users.noreply.github.com>
…H_ENGINE_OPEN_SEARCH_RESOURCE_INDEX_NAME
ace7de9 to
b0d484b
Compare
micbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small questions.
| Bleve is a lightweight, embedded full-text search engine written in Go and is the default search backend. | ||
| It is easy to set up and requires no additional services to run. | ||
|
|
||
| Note that as of now, the search service can not be scaled. Consider using a dedicated hardware for this service in case more resources are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the info about the missing scalability
Valid Point; I’ll do a follow up pr Tomorrow, thanks for the Input |
Description
Recently we've added support for open-search as distributed search backend... the readme was outdated and hadn't mentioned anything about it yet. At the same time, I also reduced the complexity and the level of detail
Related Issue