[full-ci][tests-only] revert behat version and fix regex on test script #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant-gurung899
force-pushed
the
update-script
branch
from
b102c1a to
8ffd52b
Compare
1 task
prashant-gurung899
requested review from
PrajwolAmatya,
ScharfViktor,
anon-pradip and
individual-it
individual-it
requested changes
Sep 15, 2025
tests/acceptance/run.sh
Outdated
| # https://stackoverflow.com/questions/23416278/how-to-strip-ansi-escape-sequences-from-a-variable | ||
| # for ideas. | ||
| FAILED_SCENARIO_PATHS=$(echo "${FAILED_SCENARIO_PATHS_COLORED}" | sed "s/\x1b[^m]*m//g") | ||
| FAILED_SCENARIO_PATHS=$(echo "${FAILED_SCENARIO_PATHS_COLORED}" | sed "s/\x1b\[[0-9;]*m//g" | sed 's/\(\.feature:[0-9]\+\).*/\1/') |
Contributor
There was a problem hiding this comment.
not sure why you have changed the first regex, but I think we can make the second easier to read and the whole thing easier to understand
Suggested change
| FAILED_SCENARIO_PATHS=$(echo "${FAILED_SCENARIO_PATHS_COLORED}" | sed "s/\x1b\[[0-9;]*m//g" | sed 's/\(\.feature:[0-9]\+\).*/\1/') | |
| FAILED_SCENARIO_PATHS=$(echo "${FAILED_SCENARIO_PATHS_COLORED}" | sed "s/\x1b[^m]*m//g") | |
| # some comment that explains what happens here, because the above comment only talks about the color codes | |
| FAILED_SCENARIO_PATHS=$(echo "${FAILED_SCENARIO_PATHS}" | sed 's/\(on line \d+\)//') |
Contributor
Author
There was a problem hiding this comment.
Both made easier to read ✔️
Contributor
Author
There was a problem hiding this comment.
That didnt work so sticking with the earlier regex pattern i.e. sed 's/\(\.feature:[0-9]\+\).*/\1/' that just get rids of everything after *.feature:55.
Please, re-review @individual-it
prashant-gurung899
force-pushed
the
update-script
branch
from
8ffd52b to
93166d5
Compare
individual-it
approved these changes
Sep 15, 2025
Contributor
|
I don't think it worked as intended |
Contributor
Author
Hmmmm. I dont think the failures are because of Behat. Restarted the build. |
prashant-gurung899
force-pushed
the
update-script
branch
2 times, most recently
from
20be11b to
ce76750
Compare
Contributor
Author
|
Converting to draft. The |
prashant-gurung899
removed request for
PrajwolAmatya,
ScharfViktor,
anon-pradip and
phil-davis
prashant-gurung899
force-pushed
the
update-script
branch
6 times, most recently
from
6d6d272 to
2ec6a61
Compare
Signed-off-by: prashant-gurung899 <prasantgrg777@gmail.com>
prashant-gurung899
force-pushed
the
update-script
branch
from
2ec6a61 to
32f35f7
Compare
prashant-gurung899
requested review from
PrajwolAmatya,
anon-pradip,
individual-it and
phil-davis
individual-it
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the behat version that was changed as temporary fix in this PR
And also fixes the regex to display the line number of failed tests -> A new feature introduced by Behat in
3.24.0.New format in
v3.24.0:coreApiAuth/webDavMKCOLAuth.feature:42 (on line 50)Previous versions v3.13:
coreApiAuth/webDavMKCOLAuth.feature:42So this PR adds another sed command that removes everything after
.feature:X, including the new (on line X) text.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: