-
Notifications
You must be signed in to change notification settings - Fork 157
Fix graceful shutdown #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix graceful shutdown #1478
Conversation
14cc604 to
94cd4d9
Compare
94cd4d9 to
304649b
Compare
|
I rebased this PR after the pending PRs got merged. It does include a reva bump which also pulls in other vendor changes. Other than that the PR changes every service to use the runner package. This allows a clean graceful shutdown of every service. It can be tested by sending a SIGTERM to the process or hitting Ctrl-C. The log will then show that all services are shutting down. Without this PR the first reva service completing his Stop function would |
On which log level do we log that? Info level? |
micbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall implementation looks good. I have some questions on the log levels.
micbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements, makes the whole process clearer and more consistent.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
afd7de6 to
0814a60
Compare
backport of owncloud/ocis#11295
includes #1416 so we should merge that first
requires reva changes opencloud-eu/reva#326