Skip to content

Conversation

@butonic
Copy link
Contributor

@butonic butonic commented Sep 8, 2025

backport of owncloud/ocis#11295
includes #1416 so we should merge that first
requires reva changes opencloud-eu/reva#326

@butonic butonic force-pushed the fix-graceful-shutdown branch from 14cc604 to 94cd4d9 Compare September 8, 2025 15:38
@butonic butonic added Type:Bug Type:Maintenance E.g. technical debt, packaging, etc. and removed Type:Bug Type:Maintenance E.g. technical debt, packaging, etc. labels Sep 8, 2025
@butonic butonic self-assigned this Sep 8, 2025
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Sep 8, 2025
@butonic butonic moved this from Qualification to In Progress in OpenCloud Team Board Sep 8, 2025
@butonic butonic added Type:Maintenance E.g. technical debt, packaging, etc. and removed Type:Bug labels Sep 8, 2025
@butonic butonic requested review from rhafer and removed request for rhafer September 8, 2025 16:18
@butonic butonic marked this pull request as draft September 8, 2025 16:18
@butonic butonic mentioned this pull request Sep 8, 2025
@butonic butonic force-pushed the fix-graceful-shutdown branch from 94cd4d9 to 304649b Compare September 11, 2025 08:40
@butonic butonic requested review from micbar and rhafer September 11, 2025 08:47
@butonic butonic marked this pull request as ready for review September 11, 2025 08:47
@butonic
Copy link
Contributor Author

butonic commented Sep 11, 2025

I rebased this PR after the pending PRs got merged. It does include a reva bump which also pulls in other vendor changes.

Other than that the PR changes every service to use the runner package. This allows a clean graceful shutdown of every service.

It can be tested by sending a SIGTERM to the process or hitting Ctrl-C. The log will then show that all services are shutting down.

Without this PR the first reva service completing his Stop function would exit(0) preventing other services from shutting down properly.

@micbar
Copy link
Contributor

micbar commented Sep 11, 2025

It can be tested by sending a SIGTERM to the process or hitting Ctrl-C. The log will then show that all services are shutting down.

On which log level do we log that? Info level?

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall implementation looks good. I have some questions on the log levels.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements, makes the whole process clearer and more consistent.

jvillafanez and others added 11 commits September 12, 2025 12:18
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the fix-graceful-shutdown branch from afd7de6 to 0814a60 Compare September 12, 2025 10:19
@butonic butonic merged commit 8d39655 into main Sep 12, 2025
58 checks passed
@butonic butonic deleted the fix-graceful-shutdown branch September 12, 2025 11:00
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenCloud Team Board Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants