Nats connection names #1416
Merged
Nats connection names #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
butonic
force-pushed
the
nats-connection-names
branch
from
97fdea6 to
e7a6d99
Compare
rhafer
requested changes
Sep 9, 2025
Contributor
rhafer
left a comment
rhafer
left a comment
There was a problem hiding this comment.
lgtm, apart from the weird firstNRunes implementation.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
approved these changes
Sep 11, 2025
github-project-automation
bot
moved this from In Progress
to Done
in OpenCloud Team Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of owncloud/ocis#11144
first half of #1478