-
Notifications
You must be signed in to change notification settings - Fork 157
[full-ci] run tests with VIPS enabled #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2294ea to
98d10b0
Compare
|
strict comparing for image files works fine but for .txt file fails in CI (but works fine localy) Perhaps my how to do it:
|
|
@ScharfViktor can you try with a bigger size preview? because for me (using the docker container) it does not work. It only returns squares: |
|
I got the fixure image on a remote Linux computer with |
|
but the test doesn't work. even when we use Latin |
6596e84 to
6a05a8d
Compare
| When user "Alice" downloads the preview of "/lorem.txt" with width "32" and height "32" using the WebDAV API | ||
| When user "Alice" downloads the preview of "/lorem.txt" with width "1200" and height "1200" using the WebDAV API | ||
| Then the HTTP status code should be "200" | ||
| And the downloaded image should be "32" pixels wide and "32" pixels high |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are checking the size in every other test except of here, any special reason for that?
theoretically we don't need to check the size, because we are trying to match the file anyway. so if the size would be wrong the test would also fail
tests/acceptance/features/coreApiWebdavPreviews/previews.feature
Outdated
Show resolved
Hide resolved
1dabf0b to
3699192
Compare
cb1c4d3 to
c08f950
Compare
* [full-ci] run tests with VIPS enabled * fix * fix --------- Co-authored-by: Viktor Scharf <v.scharf@opencloud.eu>



Description
Run acceptance tests with VIPS by default
Related Issue
opencloud-eu/qa#43
opencloud-eu/qa#66
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: