-
Notifications
You must be signed in to change notification settings - Fork 158
multiTenancyTests #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiTenancyTests #1313
Conversation
9607a62 to
c87196f
Compare
|
Test is failed but shouldn't I tried to reproduce on fresh main and now it doesn't work as expected: steps:
@aduffeck @dragonchaser Maybe I forgot something? |
c87196f to
c8e1d1c
Compare
I forgot to bump reva. re-run after rebase |
aduffeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm besides the nitpick
|
|
||
|
|
||
| Scenario: users from different companies cannot see each other | ||
| When user "David" searches for user "brian" using Graph API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe search for ali here as well? Otherwise it could happen that the test data gets changed in the future (e.g. Brian gets dropped) and then this test would give false positives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test cannot give false positives because when Brian gets dropped then -> we get a problem in the first test where we use When user "Brian" searches for user "ali" using Graph API
related #1274
Test uses prepared LDAP users where we have users from two tenancy
tenancy1:
alice,brianandadmin(need for CI)tenancy2:
carolanddavidHow to run localy:
../../../tests/config/woodpecker/ldap:/ldifsOC_LDAP_USER_SCHEMA_TENANT_ID: "departmentNumber"OC_LDAP_USER_ENABLED_ATTRIBUTE: ""OC_LDAP_USER_FILTER: "(objectclass=inetOrgPerson)"OC_MULTI_TENANT_ENABLED: "true"GROUPS_DRIVER: "null"GRAPH_IDENTITY_BACKEND: "cs3"docker compose up -dUSE_PREPARED_LDAP_USERS=true TEST_SERVER_URL=https://cloud.opencloud.test BEHAT_FEATURE=tests/acceptance/features/apiTenancy/mutltiTenancy.feature make test-acceptance-api