Tenant #1274
Merged
Tenant #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
force-pushed
the
tenant-id
branch
4 times, most recently
from
08172c6 to
2c20d36
Compare
butonic
reviewed
Aug 5, 2025
Comment on lines
+64
to
+74
| logger.Error().Str("backend", "cs3").Err(err).Str("nameOrId", nameOrId).Msg("error sending get user by claim id grpc request: transport error") | ||
| return nil, errorcode.New(errorcode.ServiceNotAvailable, err.Error()) | ||
| case res.GetStatus().GetCode() == cs3rpc.Code_CODE_OK: | ||
| return CreateUserModelFromCS3(res.GetUser()), nil | ||
| case res.GetStatus().GetCode() == cs3rpc.Code_CODE_NOT_FOUND: | ||
| // If the user was not found by username, try to get it by user ID | ||
| default: | ||
| logger.Debug().Str("backend", "cs3").Err(err).Str("nameOrId", nameOrId).Msg("error sending get user by claim id grpc request") | ||
| return nil, errorcode.New(errorcode.GeneralException, res.GetStatus().GetMessage()) | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
What if the search returns more than one user? names may not be unique
butonic
approved these changes
Aug 5, 2025
15 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added support for tenantIds for users. Adapted the CreateShare Endpoints to respect theseif used.
refs #877