-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add enode link URL endpoint #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8036a86
Add enode link URL endpoint
AndrewLester 27c4d2e
Fix lint
AndrewLester 40690d7
Rename test var for clarity
AndrewLester 910a5a9
Add comment to mock urls fixtuer
AndrewLester d26af24
Use redirect response
AndrewLester baa189b
Merge remote-tracking branch 'origin/h4i/enode' into al/enode-link
AndrewLester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
def test_get_enode_link_fake(client, fake): | ||
params = {"redirect_uri": "https://example.org"} | ||
response = client.get("/enode/link", params=params, follow_redirects=False) | ||
|
||
assert response.status_code == 307 | ||
assert len(response.headers["location"]) > 0 | ||
|
||
|
||
def test_get_enode_link(client, clients, httpx_mock): | ||
test_enode_link_uri = "https://example.com" | ||
|
||
httpx_mock.add_response( | ||
url=f"https://enode-api.production.enode.io/users/{clients[0].client_uuid}/link", | ||
json={"linkUrl": test_enode_link_uri}, | ||
) | ||
|
||
params = {"redirect_uri": "https://example.org"} | ||
response = client.get( | ||
"/enode/link", | ||
params=params, | ||
follow_redirects=False, | ||
) | ||
|
||
assert response.status_code == 307 | ||
assert response.headers["location"] == test_enode_link_uri |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can just do this with a fastapi RedirectResponse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opted for this in the end. On the frontend, we can just use a
fetch
as usual, we just won't read the response body (Enode Link UI) and instead just history push the page to theResponse.url
.