Add enode link URL endpoint #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## h4i/enode #86 +/- ##
=============================================
+ Coverage 86.93% 91.97% +5.04%
=============================================
Files 9 8 -1
Lines 398 324 -74
=============================================
- Hits 346 298 -48
+ Misses 52 26 -26
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericcccsliu
approved these changes
Apr 19, 2023
Comment on lines
+371
to
+377
| with httpx.Client() as httpx_client: | ||
| data = {"vendorType": "inverter", "redirectUri": redirect_uri} | ||
| res = httpx_client.post( | ||
| f"https://enode-api.production.enode.io/users/{client.client_uuid}/link", data=data | ||
| ).json() | ||
|
|
||
| return res["linkUrl"] |
There was a problem hiding this comment.
Do you think we can just do this with a fastapi RedirectResponse?
There was a problem hiding this comment.
Opted for this in the end. On the frontend, we can just use a fetch as usual, we just won't read the response body (Enode Link UI) and instead just history push the page to the Response.url.
ericcccsliu
approved these changes
Apr 20, 2023
AndrewLester
added a commit
that referenced
this pull request
Apr 23, 2023
* Add enode link URL endpoint * Fix lint * Rename test var for clarity * Add comment to mock urls fixtuer * Use redirect response
AndrewLester
added a commit
that referenced
this pull request
Apr 24, 2023
* Add enode link URL endpoint * Fix lint * Rename test var for clarity * Add comment to mock urls fixtuer * Use redirect response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds an endpoint for getting a valid Enode link URL for a user.
Fixes #72
Need to use env vars for Enode URLs, but coming in another PR
How Has This Been Tested?
Adds a test for both fake and mock Enode requests.
Checklist: