New way of editing categories and scales #547
Conversation
JulianKniephoff
force-pushed
the
category-and-scale-modals
branch
4 times, most recently
from
973bd73 to
59a85db
Compare
Only has "create category" option for now. Still needs styling.
Just added this so you have any option to create/edit categories at all. - Need to make new modals that properly reflect "create" and "edit" - Old scale modal is category bound, maybe it should not be?
This also restores the property of color generation where the next color is completely determined by the current set of categories, instead of by how often the generation was called.
JulianKniephoff
force-pushed
the
category-and-scale-modals
branch
from
c3c4426 to
359e2bc
Compare
This makes it more clear that it can only contain numerical values. Addresses opencast#537.
JulianKniephoff
force-pushed
the
category-and-scale-modals
branch
from
9f06cf6 to
d9a412c
Compare
JulianKniephoff
force-pushed
the
category-and-scale-modals
branch
from
d7d69a9 to
9ec01d4
Compare
JulianKniephoff
force-pushed
the
category-and-scale-modals
branch
from
9ec01d4 to
6ae9a70
Compare
Arnei
left a comment
Arnei
left a comment
There was a problem hiding this comment.
This has been less of a code review and more a "Arne learns about javascript" session, but I still daresay this PR looks generally good to me. Some issues I found are listed below.
Should this include a notice about upgrading the db, since a new a new column was added to LabelImpl?
The text in the "Add Track"-Modal is all white, making it unreadable against the white background. Seems to be an inheritance issue somehow.
The assumption behind it was not valid: Videos that are annotated for the first time don't have an ID at that point, but might still have child resources we might want to load, namely series categories. Fixes opencast#574.
Unfortunately we still haven't figured out a good way/place to put such notices. 😞
Will be addressed in #548. |
2 participants
This implements a new paradigm for editing categories and scales, as prescribed by the Bern 2021-1 project.
Note that this includes #546 and Arnei#8, and hence Arnei#7 and #414.