Series categories review #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Mine"-Categories visible to other users will appear in their own tab, as well as in all. "Mine"-Categories visible to other users cannot be interacted with.
Previously would show category tabs for every user that annotated anything to the current video. Now only shows user category tab, if at least one of their tracks was set to visible
- Still bugged in many ways tho.
…lity-of-mine-categories
- By renaming a css rule set that had no business being called "read-only" - This also fixes Non-Mine-Categories accidentally having a "read-only" style
- createsAsMine categories could appear in the all tab before their respective tracks were visible. This is now fixed.
…ity-of-mine-categories Consider `access` when comparing categories
This is done by the backend. The code in question was only in place to support the `localStorage` use-case, which we don't support anymore.
This is only necessary if the function in question refers to `this` at all which is not the case here.
This consolidates some of the information about the video returned by the integration layer and stores them on the global `Video`. This makes it simpler to work with this data in some places.
JulianKniephoff
force-pushed
the
series-categories-review
branch
from
7537544 to
1dfb190
Compare
JulianKniephoff
force-pushed
the
series-categories-review
branch
from
8b5f11e to
00388e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there probably just won't be enough time right now to do a full review of opencast#414. However, I started one once, so we can at least try to integrate the stuff I found during that.
This contains mostly stylistic nitpicking and a few minor refactorings. Not all of them have to do with your code, either. It's just whatever I found while scouring the changes. 🤷 So I guess you don't have to review every single change, but feel free to skim it to see what I would change. The more important thing for me here is to have a second person test this. 😅
Note that this includes #7, which should probably be merged first.