Skip to content

Conversation

@eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented Sep 9, 2025

Service admin can:

  • update any resource
  • update any field in the schema
  • added missing endpoints for all routes

@eleftherioszisis eleftherioszisis changed the base branch from main to update September 9, 2025 15:34
Base automatically changed from update to main September 11, 2025 09:17
@eleftherioszisis eleftherioszisis changed the title Add admin update endpoints Add update endpoints for service admins Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/service/em_cell_mesh.py 60.00% 2 Missing ⚠️
app/service/license.py 75.00% 2 Missing ⚠️
app/service/experimental_bouton_density.py 50.00% 1 Missing ⚠️
app/service/ion_channel_recording.py 75.00% 1 Missing ⚠️
app/service/simulation_campaign.py 50.00% 1 Missing ⚠️
app/utils/routers.py 66.66% 1 Missing ⚠️
Flag Coverage Δ
pytest 96.52% <97.56%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/db/utils.py 81.81% <100.00%> (ø)
app/queries/common.py 96.55% <100.00%> (+2.84%) ⬆️
app/routers/brain_region.py 100.00% <100.00%> (ø)
app/routers/calibration.py 100.00% <100.00%> (ø)
app/routers/circuit.py 100.00% <100.00%> (ø)
app/routers/electrical_cell_recording.py 100.00% <100.00%> (ø)
app/routers/electrical_recording_stimulus.py 100.00% <100.00%> (ø)
app/routers/em_cell_mesh.py 100.00% <100.00%> (ø)
app/routers/emodel.py 100.00% <100.00%> (ø)
app/routers/etype.py 100.00% <100.00%> (ø)
... and 93 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eleftherioszisis eleftherioszisis marked this pull request as ready for review September 12, 2025 12:50
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the slog; seems reasonable to me, couple small comments.

@mgeplf
Copy link
Collaborator

mgeplf commented Sep 23, 2025

LGTM, I will let @GianlucaFicarelli have a look - I could approve before Thursday if he doesn't have the time.

Copy link
Collaborator

@GianlucaFicarelli GianlucaFicarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleftherioszisis eleftherioszisis merged commit bb0ef66 into main Sep 23, 2025
2 checks passed
@eleftherioszisis eleftherioszisis deleted the update-admin branch September 23, 2025 11:50
GianlucaFicarelli added a commit that referenced this pull request Sep 23, 2025
* origin/main:
  Add update endpoints for service admins (#355)
  Add read endpoints for service admins (#354)
  Validate types in SimulationExecutionFilter and ElectricalRecordingStimulusFilter (#369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants