Skip to content

Conversation

@eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented Sep 9, 2025

@eleftherioszisis eleftherioszisis changed the title Example of admin read route Add admin read endpoints Sep 9, 2025
@eleftherioszisis eleftherioszisis force-pushed the admin-read branch 2 times, most recently from b2989f5 to 045988c Compare September 11, 2025 10:19
@eleftherioszisis eleftherioszisis changed the title Add admin read endpoints Add read endpoints for service admins Sep 11, 2025
@eleftherioszisis eleftherioszisis marked this pull request as ready for review September 12, 2025 12:50
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 93.64407% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/service/brain_atlas.py 50.00% 1 Missing ⚠️
app/service/calibration.py 50.00% 1 Missing ⚠️
app/service/consortium.py 50.00% 1 Missing ⚠️
app/service/contribution.py 50.00% 1 Missing ⚠️
app/service/emodel.py 50.00% 1 Missing ⚠️
app/service/measurement_annotation.py 50.00% 1 Missing ⚠️
app/service/memodel.py 50.00% 1 Missing ⚠️
app/service/morphology.py 50.00% 1 Missing ⚠️
app/service/organization.py 50.00% 1 Missing ⚠️
app/service/person.py 50.00% 1 Missing ⚠️
... and 5 more
Flag Coverage Δ
pytest 96.42% <93.64%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/repository/asset.py 100.00% <100.00%> (ø)
app/routers/admin.py 100.00% <100.00%> (ø)
app/routers/brain_atlas.py 100.00% <100.00%> (ø)
app/routers/calibration.py 100.00% <100.00%> (ø)
app/routers/cell_composition.py 100.00% <100.00%> (ø)
app/routers/circuit.py 100.00% <100.00%> (ø)
app/routers/consortium.py 100.00% <100.00%> (ø)
app/routers/contribution.py 100.00% <100.00%> (ø)
app/routers/electrical_cell_recording.py 100.00% <100.00%> (ø)
app/routers/electrical_recording_stimulus.py 100.00% <100.00%> (ø)
... and 69 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sucks to have so much duplication, but I suppose that's the best way; another layer of abstraction would probably bite us in the future.

@eleftherioszisis eleftherioszisis merged commit e358aa6 into main Sep 18, 2025
1 of 2 checks passed
@eleftherioszisis eleftherioszisis deleted the admin-read branch September 18, 2025 12:02
GianlucaFicarelli added a commit that referenced this pull request Sep 23, 2025
* origin/main:
  Add update endpoints for service admins (#355)
  Add read endpoints for service admins (#354)
  Validate types in SimulationExecutionFilter and ElectricalRecordingStimulusFilter (#369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants