Skip to content

Make EModel read_one/read_many schemas consistent #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Make EModel read_one/read_many schemas consistent #177

merged 2 commits into from
May 19, 2025

Conversation

@eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented May 19, 2025

@g-bar
Copy link
Contributor

g-bar commented May 19, 2025 •
edited
Loading

Thanks, I was going to make the change 😑

Didn't we also need to make the exemplar_morphology consistent with ReconstructionMorphologyRead?

g-bar
g-bar reviewed May 19, 2025
View reviewed changes
@eleftherioszisis
Copy link
Contributor Author

eleftherioszisis commented May 19, 2025

Didn't we also need to make the exemplar_morphology consistent with ReconstructionMorphologyRead?

I made the fields optional in the morph model in the sdk, so it will work even with the simplified morphology.

@g-bar
Copy link
Contributor

g-bar commented May 19, 2025

LGTM, thanks for the change @eleftherioszisis

@g-bar g-bar self-requested a review May 19, 2025 11:21
AurelienJaquier
AurelienJaquier approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@eleftherioszisis eleftherioszisis merged commit bcebef1 into main May 19, 2025
1 check passed
@eleftherioszisis eleftherioszisis deleted the fix-emodel-endpoint-consistency branch May 19, 2025 11:29
GianlucaFicarelli added a commit that referenced this pull request May 19, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into improve_filter_query
33cc673 
* origin/main:
  Add synaptome assets label (#176)
  Make EModel read_one/read_many schemas consistent (#177)
@GianlucaFicarelli GianlucaFicarelli mentioned this pull request May 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g-bar g-bar g-bar approved these changes

@GianlucaFicarelli GianlucaFicarelli GianlucaFicarelli left review comments

@AurelienJaquier AurelienJaquier AurelienJaquier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot retrieve ion_channel_models from database, nor examplar_morpholgy.brain_region or examplar_morphology.species

5 participants

@eleftherioszisis @g-bar @GianlucaFicarelli @AurelienJaquier