Skip to content

Add synaptome assets label #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

Add synaptome assets label #176

merged 3 commits into from
May 19, 2025

Conversation

@bilalesi
Copy link
Contributor

@bilalesi bilalesi commented May 19, 2025

  1. add synaptome asset label for both: synaptome configuration and single neuron synaptme simulation
  2. add entity type to ion-channel

eleftherioszisis
eleftherioszisis approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bilalesi bilalesi requested a review from eleftherioszisis May 19, 2025 10:22
@g-bar
Copy link
Contributor

g-bar commented May 19, 2025

Need to fix the linter but LGTM.

@bilalesi bilalesi force-pushed the add-synaptome-assets-label branch from 2a6b31f to 05f4dac Compare May 19, 2025 11:36
@bilalesi bilalesi force-pushed the add-synaptome-assets-label branch from 05f4dac to 2a3060a Compare May 19, 2025 11:37
@bilalesi bilalesi merged commit 0d79b13 into main May 19, 2025
1 check passed
@bilalesi bilalesi deleted the add-synaptome-assets-label branch May 19, 2025 11:41
GianlucaFicarelli added a commit that referenced this pull request May 19, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into improve_filter_query
33cc673 
* origin/main:
  Add synaptome assets label (#176)
  Make EModel read_one/read_many schemas consistent (#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g-bar g-bar g-bar approved these changes

@GianlucaFicarelli GianlucaFicarelli Awaiting requested review from GianlucaFicarelli

@eleftherioszisis eleftherioszisis Awaiting requested review from eleftherioszisis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bilalesi @g-bar @eleftherioszisis