Skip to content

feat: Better typing (mypy) support for Unset (e.g., using if statements to check type) [#714, #752]. Thanks @taasan & @mcclurem! #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2023
Merged

feat: Better typing (mypy) support for Unset (e.g., using if statements to check type) [#714, #752]. Thanks @taasan & @mcclurem! #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
310392b
help mypy figure out that 'Unset' is always falsey
Apr 24, 2023
be5c2f7
Merge branch 'main' into main
dbanty Apr 30, 2023
5bfe3ec
chore: Regen tests
dbanty Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions end_to_end_tests/golden-record/my_test_api_client/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
""" Contains some shared types for properties """
from http import HTTPStatus
from typing import BinaryIO, Generic, MutableMapping, Optional, Tuple, TypeVar
from typing import BinaryIO, Generic, Literal, MutableMapping, Optional, Tuple, TypeVar

import attr


class Unset:
def __bool__(self) -> bool:
def __bool__(self) -> Literal[False]:
return False


Expand Down
4 changes: 2 additions & 2 deletions integration-tests/integration_tests/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
""" Contains some shared types for properties """
from http import HTTPStatus
from typing import BinaryIO, Generic, MutableMapping, Optional, Tuple, TypeVar
from typing import BinaryIO, Generic, Literal, MutableMapping, Optional, Tuple, TypeVar

import attr


class Unset:
def __bool__(self) -> bool:
def __bool__(self) -> Literal[False]:
return False


Expand Down
4 changes: 2 additions & 2 deletions openapi_python_client/templates/types.py.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
""" Contains some shared types for properties """
from http import HTTPStatus
from typing import Any, BinaryIO, Generic, MutableMapping, Optional, Tuple, TypeVar
from typing import Any, BinaryIO, Generic, MutableMapping, Optional, Tuple, TypeVar, Literal

import attr


class Unset:
def __bool__(self) -> bool:
def __bool__(self) -> Literal[False]:
return False


Expand Down