feat: Better typing (mypy) support for Unset (e.g., using if statements to check type) [#714, #752]. Thanks @taasan & @mcclurem!
#752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Fixes #714, pretty sure it doesn't work in Python 3.7, though, so this will have to be after we drop support for it (which will be soon). |
Contributor
Author
|
Would ifdefing it with sys.version_info be considered acceptable to get it included sooner? Alternatively ifdefing an import of Literal from typing_extensions? |
Collaborator
|
3.7 is EoL in 2 months, so I'll probably just remove support in the next release |
dbanty
changed the title
Unset (e.g., using if statements to check type) [#714, #752]. Thanks @taasan & @mcclurem!
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1971 1971
=========================================
Hits 1971 1971 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbanty
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy can't currently detect that an "Unset" is falsey. By changing the bool annotation in types.py, we can give it the help it needs