Skip to content

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Jan 26, 2026

Summary

Refines the bottom footer layout to keep % context left right-aligned while making the left side degrade cleanly

Behavior with empty textarea

Full width:
Screenshot 2026-01-26 at 2 59 59 PM
Less:
Screenshot 2026-01-26 at 2 59 48 PM
Min width:
Screenshot 2026-01-26 at 2 59 33 PM

Behavior with message in textarea and agent running (steer enabled)

Full width:
Screenshot 2026-01-26 at 4 33 54 PM

Less:
Screenshot 2026-01-26 at 4 30 12 PM

Less:
Screenshot 2026-01-26 at 4 30 51 PM

Less:
Screenshot 2026-01-26 at 4 30 56 PM

Less:
Screenshot 2026-01-26 at 4 31 08 PM

Notes / Edge Cases

  • In steer mode while typing, the queue hint no longer replaces the mode label; it renders as tab to queue message · {Mode}.
  • Collapse priorities differ by state:
    • With the queue hint active, % context left is hidden before shortening or dropping the queue hint.
    • In the empty + non-running state, ? for shortcuts is dropped first, and % context left is only shown if (shift+tab to cycle) can also fit.
  • Transient instructional states (? overlay, Esc hint, Ctrl+C/D reminders, and flash/override hints) intentionally suppress the
    mode label (and context) to focus the next action.

Implementation Notes

  • Renamed the base footer modes to make the state explicit: ComposerEmpty and ComposerHasDraft, and compute the base mode
    directly from emptiness.
  • Unified collapse behavior in single_line_footer_layout for both base modes, with:
    • Queue-hint behavior that prefers keeping the queue hint over context.
    • A cycle-hint guard that prevents context from reappearing after (shift+tab to cycle) is dropped.
  • Kept rendering responsibilities explicit:
    • single_line_footer_layout decides what fits.
    • render_footer_line renders a chosen line.
    • render_footer_from_props renders the canonical mode-to-text mapping.
  • Expanded snapshot coverage:
    • Added footer_collapse_snapshots in chat_composer.rs to lock the distinct collapse states across widths.
    • Consolidated the width-aware snapshot helper usage (e.g., snapshot_composer_state_with_width,
      snapshot_footer_with_mode_indicator).

@charley-oai charley-oai changed the title TUI footer: right-align context and degrade shortcut summary + mode c… TUI footer: right-align context and degrade shortcut summary + mode cleanly Jan 26, 2026
@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39814827e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dcc6b1274

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30d6fedbca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai marked this pull request as ready for review January 27, 2026 09:40
@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai enabled auto-merge (squash) January 27, 2026 17:28
@charley-oai charley-oai merged commit 538e105 into main Jan 27, 2026
32 checks passed
@charley-oai charley-oai deleted the tweak-tui-footer-text branch January 27, 2026 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants