Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill diff_file_index and diff_line_number columns on table comments #16969

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Backfill diff_file_index and diff_line_number columns on table comments #16969

merged 1 commit into from
Oct 18, 2024
+22 −1

Conversation

eduardoj
Copy link
Member

Follow up to #16966.

This PR belongs to a series to avoid downtime. The steps are:

  1. Add new columns
  2. Write to all three columns
  3. Backfill data from the old column to the new columns ⬅️
  4. Move reads from the old column to the new columns
  5. Stop writing to the old column
  6. Drop the old column

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Oct 17, 2024
@eduardoj eduardoj force-pushed the refactoring/replace_diff_ref_iii branch 2 times, most recently from 718b0fb to 73557b2 Compare October 17, 2024 13:03
@eduardoj eduardoj force-pushed the refactoring/replace_diff_ref_iii branch from 73557b2 to 6dddef2 Compare October 17, 2024 13:23
@eduardoj eduardoj mentioned this pull request Oct 17, 2024
Merged
@eduardoj eduardoj marked this pull request as ready for review October 18, 2024 09:38
@eduardoj eduardoj force-pushed the refactoring/replace_diff_ref_iii branch from 6dddef2 to fd1cc2d Compare October 18, 2024 10:32
@eduardoj eduardoj merged commit f144394 into openSUSE:master Oct 18, 2024
22 checks passed
@eduardoj eduardoj deleted the refactoring/replace_diff_ref_iii branch October 18, 2024 11:01
@rubhanazeem rubhanazeem mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hennevogel hennevogel hennevogel approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoj @hennevogel