Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write to diff_file_index and diff_line_number columns #16966

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Write to diff_file_index and diff_line_number columns #16966

merged 1 commit into from
Oct 17, 2024
+7 −3

Conversation

eduardoj
Copy link
Member

Follow up to #16965.

This PR belongs to a series to avoid downtime. The steps are:

  1. Add new columns
  2. Write to all three columns ⬅️
  3. Backfill data from the old column to the new columns
  4. Move reads from the old column to the new columns
  5. Stop writing to the old column
  6. Drop the old column

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Oct 16, 2024
@eduardoj eduardoj marked this pull request as ready for review October 17, 2024 09:33
hellcp-work
hellcp-work approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@hellcp-work hellcp-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase with recent changes, otherwise looks good

@eduardoj eduardoj force-pushed the refactoring/replace_diff_ref_ii branch from f9a3b99 to 7a550a2 Compare October 17, 2024 12:19
@eduardoj eduardoj mentioned this pull request Oct 17, 2024
Merged
@eduardoj eduardoj merged commit cfc5dac into openSUSE:master Oct 17, 2024
20 of 21 checks passed
@eduardoj eduardoj deleted the refactoring/replace_diff_ref_ii branch October 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellcp-work hellcp-work hellcp-work approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoj @hellcp-work